[nodes] Masking: Handle file extensions for masks and mask inversion for ImageSegmentation
#2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `maskExtension` parameter to specify the extension (by default, "png") of the masks that are to be loaded.
The segmentation masks are now inverted during the `ImageSegmentation` process, thus the `FeatureExtraction` node does not need to do it anymore. In the CameraTracking pipeline, the `PrepareDenseScene` is now provided with the masks from the `ImageSegmentation` node.
mugulmd
approved these changes
Aug 25, 2023
cbentejac
added a commit
that referenced
this pull request
Jan 10, 2024
Update from 1.0 to 1.2. The update to 1.1 that should have occurred with #2165 has been forgotten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reflects the changes made in alicevision/AliceVision#1517 to handle other file extensions than "png" for masks and to invert mask values in the
ImageSegmentationnode.Additionally, the "Camera Tracking" and "Camera Tracking and Photogrammetry" templates are updated as follows:
maskInvertattribute of theImageSegmentationnode is enabled;maskInvertattribute of theFeatureExtractionnode is disabled;ImageSegmentationnode is connected to thePrepareDenseScene's input.Features list
MeshMaskingandPrepareDenseScenenodes now havemaskExtensionparameters;ImageSegmentationnode now has anmaskInvertparameter to invert the output masks' values;